aarch64 implement brz,brnz,br_icmp for i128 values#3002
Merged
Conversation
Lowering icmp was duplicated across callers that only cared about flags, and callers that only cared about the bool result. Merge both callers into `lower_icmp` which does the correct thing depending on a new IcmpOutput parameter.
The previous commit deduplicated the icmp impl, so we reuse that but make modifications where we don't need to set the results.
github-actions
Bot
added
cranelift
cfallin
approved these changes
Jun 21, 2021
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
Thanks for this, especially the very thorough tests!
I have one comment below on a possible optimization and am curious what you think, but am happy with this either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
This PR implements a few branches for i128 values.
It also cleans up a bit of duplicated logic for lowering icmp